search

MissionalDigerati / joshua_project_api

An API for connecting to the Joshua Project data.
GNU General Public License v3.0
6 stars 2 forks source link

Numbers Over Limit Fail With Error #4

Closed codemis closed 10 years ago

codemis commented 10 years ago

When you request people groups and submit the limit param with a number greater then the max number of rows, we get a "Server Error" warning. Here is an example: http://jpapi.codingstudio.org/v1/people_groups.json?api_key=233f76f4c84e&limit=8000. Need to make sure max limit is not greater then the number of People Group in the database. 2 options:

  1. Set a max on the limit param, and error out if request is over limit
  2. Check limit and default to max limit if it is greater
codemis commented 10 years ago

This was an issue related to the PHP settings on the development server. In order to load that much data from the server, the max_execution_time must be greater than 90 seconds. I added a line in the ReadMe.md so we do not forget.