search

Mista-Tea / improved-stacker

A complete rewrite of the Stacker tool, including multiple new features for both players and developers, as well as multiple crash fixes.
18 stars 10 forks source link

Stacker bypassing prop limit again? #2

Closed JohnAtPG closed 9 years ago

JohnAtPG commented 10 years ago

I'm not sure if I am the only one experiencing this but recently I noticed that stacker is sometimes bypassing the prop limit on my server again. I'm on the workshop version and haven't changed a thing at all.

It's happened a few times but I cannot reproduce it currently.

If there is anyway I can help, let me know. I know this may be useless but I've seen stacker bypass prop limit at least 3 times in the past week but completely random.

Mista-Tea commented 10 years ago

Hello JohnAtPG!

Thank you for taking the time to report an issue. Since it doesn't sound like this is easily replicable, do you mind telling me which gamemode and any prop protection/admin mods you use?

If you can give me any more details, it will help in tracking down the cause of the issue.

JohnAtPG commented 10 years ago

Latest DarkRP github version which comes with the following: fAdmin & Falco Prop Protection

I also use: ULX/ULIB Nadmod Prop Protection (http://steamcommunity.com/sharedfiles/filedetails/?id=159298542)

Mista-Tea commented 10 years ago

Unfortunately, I've never used or configured any of those.

I've tried searching through all of them for the hooks/functions I use to check prop limits (PLAYER:CheckLimit( "props" ) / GM:PlayerSpawnedProp) but I can't find which addon you have that actually controls prop limits. But even if I could, I don't know how you have everything configured on your end.

I don't mean to sound like I am dismissing the issue, but this is extremely difficult for me to try to replicate and I'm afraid I don't have the available time to try to grasp what each of the addons listed do internally. I have not heard of anyone else suffering from this issue, so things are even more complicated.

JohnAtPG commented 10 years ago

I understand.

I forgot to mention I have one addon that is from coderhire called dynamic-proplimit. I use it to restrict proplimit based on ULX usergroups. Since it's from coderhire and bound by license - how can I investigate this addon to see if it's the cause?

JohnAtPG commented 10 years ago

My dynamic prop limit addon has this: hook.Add( "PlayerSpawnProp", "DynamicLimit", function( ply )

Not sure if that helps at all but I'm trying to narrow it down to find out what is causing this.

Mista-Tea commented 9 years ago

I've realize it's been a very long time since this issue was last addressed, and I apologize.

I haven't received any messages of others having issues with Stacker bypassing prop limits. I hate to simply conclude that the addon you are using isn't handling prop limits correctly, but I can't think of any other reason.

PLAYER:CheckLimit( "props" ), GM:PlayerSpawnProp, GM:PlayerSpawnedProp, PLAYER:AddCleanup ( "props", ent ), and the undo library are all used when creating stacker entities. This should be more than enough for a general prop-limiting addon to properly handle.