search

MisterDA / love-release

:love_letter: Lua script that makes LÖVE game release easier
MIT License
451 stars 27 forks source link

excluding/including files #39

Open Alloyed opened 8 years ago

Alloyed commented 8 years ago

So #36 got me so I wanted to look through the source to figure out why and I saw this comment

-- @todo This function should be able to parse and use CVS files such as
-- gitignore. It should also work on the file tree rather than on the file list.

This is not what I'd want love-release to do, because the things I exclude from git are things like art and music that would bloat up the repo, and I don't think my game would be very good without art and music.

Possible alternate interface: have a love-release specific include/exclude list that just checks matches against normal lua patterns, so for example

t.releases.exclude = { "%.moon$" }

would exclude moonscript files and

t.releases.include = { "%.lua$", "^assets/" }

would only include either lua files or things in the assets dir

MisterDA commented 8 years ago

Thanks ! This is a really good note. I didn't think about the fact you pointed out about git, and I agree with you. Your proposal on include/exclude is also a very good idea.

TangentFoxy commented 6 years ago

Well the exclude half of this is implemented, but I can't help but notice the lack of include by pattern. Is there a reason behind that half not being implemented?

I would argue it is a good idea, I have a project where I'm excluding like 7 different file types during building, it'd be much easier to include .lua, .wav, and .png (the only file types that make up the completed game).