search

MisterDA / love-release

:love_letter: Lua script that makes LÖVE game release easier
MIT License
451 stars 27 forks source link

Exclude files #42

Closed TannerRogalsky closed 7 years ago

TannerRogalsky commented 7 years ago

This accomplishes what I consider to be the more important half of #39, configuration of a file exclusion list.

The implementation is fairly straightforward except for my rewrite of Project:excludeFiles. I couldn't figure out why it was written the way it was so if I've messed something up there, please let me know and I'll fix it.

MisterDA commented 7 years ago

Thank your for your involvement ! Everything seems good to me. I think that your text editor has removed some trailing spaces in README.md, they are necessary in Markdown to break lines without creating a new paragraph.

Do you prefer a merge commit or a squash 'n merge ? I'm tempted by the squash.

TannerRogalsky commented 7 years ago

Thanks for the review! I fixed the whitespace (you were right about the editor removing it) and shimmed the unpack function in the style that does not modify table. I don't have a preference for the style of merge but thanks for asking!