MisterDA / love-release

:love_letter: Lua script that makes LÖVE game release easier
MIT License
449 stars 27 forks source link

Fix issue #36 and #44 #45

Closed pablomayobre closed 7 years ago

pablomayobre commented 7 years ago

This issue was related to Lua not handling coroutines iterators right, the function being recursive generated multiple coroutine iterators and they didn't resume right.

The solution is to make the first loop non-recursive and create a secondary loop where the recursive function is called.

As proposed over at #36

pablomayobre commented 7 years ago

Thanks to @egordorichev that helped me test this over at #44

Also the linting issue is probably due to an update in Luacheck and not because of my change, I didn't even touch line 151

pablomayobre commented 7 years ago

I ignored the linter warning in the specified line, table.unpack is not available in either Lua 5.1 nor LuaJIT, yet it's used as a fallback for unpack. This is not an error on itself, but is listed as an error by Luacheck.

An alternative solution would be to remove the line 151 entirely since it's not needed if we always work in Lua 5.1/LuaJIT

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 25.225% when pulling 8797d0be587dcff7464c46c038b2734a19a55dcc on Positive07:patch-1 into 339cbe7b42ccd838b25bc93fd189c87cbbfd082b on MisterDA:master.

MisterDA commented 7 years ago

Thanks !

pablomayobre commented 7 years ago

No problem 😃