Fedora 35: Metadata Makefile Mistake

[MisterGuinness]

Last year I changed the Makefile.am for metadata.json from

nodist_extension_DATA = metadata.json $(EXTRA_EXTENSION)
EXTRA_DIST = metadata.json.in
metadata.json: metadata.json.in $(top_builddir)/config.status

to

nodist_extension_DATA = metadata.json
dist_extension_DATA = metadata.json.in
metadata.json: metadata.json.in $(top_builddir)/config.status

I've since noticed that both metadata.json and metadata.json.in are installed. I believe the original Makefile is conflicted as according to the automake docs [Section 9.3 Architecture Independent data files], "By default _DATA files are not included in a distribution... use dist_ prefix to change this" and [Section 14.1 Basics of Distribution] "...files to be distributed which are not found by automatic rules. You should mention these files in the EXTRA_DIST variable".

Definitely we want metadata.json installed, as that is read by the extension, and I can't see any reason to install metadata.json.in, but it should be included in the distribution.

[MisterGuinness]

make install now does not include metadata.json.in, but this is included in the make dist make dist does not include metadata.json make dist includes the icons