search

MisterJack49 / BankKataSolid

SOLID kata of a bank account
0 stars 0 forks source link

Your code is not upto the mark #1

Open baba199 opened 5 years ago

baba199 commented 5 years ago

Hi,

There are violations of SOLID principles at certain places. Withdrawal method is not completed and even if by adding it there is no validations or check. Just placing the code for the sack of it. Statement gets bloated when implemented with Withdrawal .. see how the deposit gets screwed on the first date (last statement in report).

image

MisterJack49 commented 5 years ago

Hi,

Thanks for your feedback, it is still a work in progress.