Open fabiancrx opened 3 years ago
Hmm, very interesting. Thanks for the help.
It feels like this should be the default behaviour for KeyboardDismissOnTap, maybe with a boolean flag to disable the drag dismissal. Would love a PR.
Nice, should I maintain the Widget as KeyboardDismissOnTap(bool dismissOnDrag,Widget child) or give it the more generic KeyboardDismiss(bool dismissOnDrag,bool dismissOnTap,Widget child) name as in the gist? My vote would be for the second option as the widget will be more generic but would not want to break versioning/compatibility for such a rather small change
Agreed on not wanting to break. Lets keep the same name.
Using the KeyboardDismissOnTap widget I wanted the keyboard to also be dismissed on drag, like Listview does so I made some changes and came up with this widget:
It does the same as KeyboardDismissOnTap but it also dismisses the keyboard on drag. If this may be considered of interest of the package users and maintainers I could make a PR to add this widget to the repo.