MisterPeModder / ShulkerBoxTooltip

What's in my shulker box?
MIT License
97 stars 31 forks source link

Common Module isn't usable #165

Closed Stein-N closed 2 months ago

Stein-N commented 2 months ago

Issue Description:

The common artifact isn't usable outside of Arch Loom Multiloader setups.

Vanilla Gradle or ModDevGradle can't remap the Yarn Intermediary mappings, would it be possible to ship a version with the official Mojang Mappings?

What happens:

BlockEntityPreviewProvider.class image image

What you expected to happen:

apply the cortrect Mappings

Steps to reproduce:

  1. Use Vanilla Gradle or ModDevGradle in common
  2. add common artifact of ShulkerBoxTooltip
  3. get the wrong mappings ...

Affected Versions (Do not use "latest"):

Your most recent log file where the issue was present:

[pastebin/gist/etc link here]

MisterPeModder commented 2 months ago

Hello, I added an artifact using official mappings (-common-mojmap). Try replacing "com.misterpemodder:shulkerboxtooltip-fabric:VERSION" by "com.misterpemodder:shulkerboxtooltip-fabric:VERSION" in your build script and tell me if it vorks ok.

Stein-N commented 2 months ago

Works great thanks :)