search

MisterPeModder / ShulkerBoxTooltip

What's in my shulker box?
MIT License
101 stars 33 forks source link

Race condition/Incompatibility when paired with Mouse Wheelie #82

Closed CompaqDisc closed 2 years ago

CompaqDisc commented 2 years ago

Issue Description:

If both ShulkerBoxTooltip and Mouse Wheelie are installed, sometimes a race condition (best guess explanation) can occur when using MWs click-dragging feature with shulker boxes. SBT will then crash trying to render a tooltip for Air (rather than the expected Shulker Box).

To figure out whether Mouse Wheelie was required to cause this crash, I simulated MWs item transfer speed with a shift-clicking macro running as fast as possible. I could not reproduce with SBT alone.

If you'd like, I'd be happy to open an issue with Mouse Wheelie if that might help.

What happens:

ShulkerBoxTooltip sometimes crashes when using Mouse Wheelie's click dragging feature with shulker boxes.

What you expected to happen:

ShulkerBoxTooltip would hopefully never crash when using Mouse Wheelie's click dragging feature with shulker boxes.

Steps to reproduce:

  1. Have both ShulkerBoxTooltip and Mouse Wheelie installed
  2. Find a multiplayer server, acquire several shulker boxes (in my particular case it was about 18 of the same color all filled with gold nuggets). (Haven't tested this in single player)
  3. Repeatedly click-drag your shulker boxes back and forth between the player inventory and a chest. (the faster you can the better)
  4. Profit?

Affected Versions (Do not use "latest"):

Installed mods and sha256sums:

8f5727abd20619d9dd64ea4166cdbeb209300f29c96baa08dfc85ea1a8cc3f13  fabric-api-0.53.4+1.18.2.jar
13b6e6e57c4f35d5e9c39948ce69292177b9b8a2dba8526e74d690a79c25756f  modmenu-3.2.2.jar
364ba7f5d572229a353b8b823683829cb50f20ef9c27383d4b39344e48ad4282  mousewheelie-1.8.8+mc1.18.2.jar
7962827a6fa4ef9bff1791d3b358e01511490d6605d72d7e3f918918acfad291  notenoughcrashes-4.1.6+1.18.2-fabric.jar
9d59d93d115ad42ff32e11b0a6d8d95c49cb2e221d0517e7ed83d43c1839b4f6  shulkerboxtooltip-3.0.7+1.18.2.jar

Your most recent log file where the issue was present:

NullPointerException: Crashy, Bytebin ClassCastException: Crashy, Bytebin latest.log hastebin: https://hst.sh/hetisakobe

CompaqDisc commented 2 years ago

Fixed in https://github.com/MisterPeModder/ShulkerBoxTooltip/commit/f68a71516b791eebf61a98302ece4eeffb032ce2