MisterTea / EternalTerminal

Re-Connectable secure remote shell
https://mistertea.github.io/EternalTerminal/
Apache License 2.0
3k stars 171 forks source link

add renovatebot #623

Closed Migelo closed 7 months ago

Migelo commented 7 months ago

As discussed in https://github.com/MisterTea/EternalTerminal/pull/622 this pull request adds the renovatebot to this repo.

The current config will automatically merge minor updates and patches, major version bumps need to be merged manually.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.22%. Comparing base (39cc495) to head (49413f3).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #623 +/- ## ========================================== + Coverage 73.09% 73.22% +0.12% ========================================== Files 49 49 Lines 3096 3096 ========================================== + Hits 2263 2267 +4 + Misses 833 829 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MisterTea commented 7 months ago

Can you add a github action to run renovate? https://github.com/renovatebot/github-action

Migelo commented 7 months ago

Something that runs every 15 minutes like this? Happy to do it!

name: Renovate
on:
  schedule:
    # The "*" (#42, asterisk) character has special semantics in YAML, so this
    # string has to be quoted.
    - cron: '0/15 * * * *'
jobs:
  renovate:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v4.1.1
      - name: Self-hosted Renovate
        uses: renovatebot/github-action@v40.1.1
        with:
          configurationFile: example/renovate-config.js
          token: ${{ secrets.RENOVATE_TOKEN }}

I never knew one can run renovate as an action, I've always just let it run on its own accord, what benefits do you recon this brings?

MisterTea commented 7 months ago

"let it run on its own accord"

What does this mean? I assumed that without a GitHub action I would need to run some command regularly to get updates.

Migelo commented 7 months ago

It just triggers every so often on its own. Without a schedule I guess it runs when the load on the bot is low? After adding renovate.json you simply need to enable https://github.com/apps/renovate for this repo and that is it, no gh action needed.

MisterTea commented 7 months ago

Oh! That's the part I was missing. Ok, with the GitHub hook we don't need an action.

Migelo commented 7 months ago

Great. Then the only thing you need to do before merging this is to add the renovate GitHub app I linked above to this repo.

MisterTea commented 7 months ago

Thanks!!