MisterTea / homebrew-et

Homebrew formula for Eternal Terminal
6 stars 9 forks source link

Install fails on macOS Sequoia #31

Open dancrossnyc opened 2 weeks ago

dancrossnyc commented 2 weeks ago

I'm seeing the following errors trying to build install on macOS Sequoia:

==> Upgrading mistertea/et/et
  6.2.9_1 -> 6.2.9_2
==> cmake . -DDISABLE_VCPKG:BOOL=ON -DPYTHON_EXECUTABLE=/usr/bin/python3
==> make install
Last 15 lines from /Users/cross/Library/Logs/Homebrew/et/02.make:
In file included from <built-in>:1:
In file included from /tmp/et-20241008-61572-e3j033/EternalTerminal-et-v6.2.9/CMakeFiles/et-lib.dir/cmake_pch.hxx:5:
In file included from /tmp/et-20241008-61572-e3j033/EternalTerminal-et-v6.2.9/src/base/Headers.hpp:8:
/tmp/et-20241008-61572-e3j033/EternalTerminal-et-v6.2.9/external_imported/cpp-httplib/httplib.h:194:10: fatal error: 'csignal' file not found
  194 | #include <csignal>
      |          ^~~~~~~~~
1 error generated.
make[2]: *** [external_imported/sentry-native/crashpad_build/third_party/mini_chromium/CMakeFiles/mini_chromium.dir/mini_chromium/base/logging.cc.o] Error 1
1 error generated.
make[2]: *** [external_imported/sentry-native/crashpad_build/third_party/mini_chromium/CMakeFiles/mini_chromium.dir/mini_chromium/base/apple/foundation_util.mm.o] Error 1
make[1]: *** [external_imported/sentry-native/crashpad_build/third_party/mini_chromium/CMakeFiles/mini_chromium.dir/all] Error 2
1 error generated.
make[2]: *** [CMakeFiles/et-lib.dir/cmake_pch.hxx.pch] Error 1
make[1]: *** [CMakeFiles/et-lib.dir/all] Error 2
make: *** [all] Error 2

If reporting this issue please do so at (not Homebrew/brew or Homebrew/homebrew-core):
  https://github.com/mistertea/homebrew-et/issues

xcode and macOS are up to date. Full make log is attached. Thanks! 02.make.txt

huyiwen commented 2 weeks ago

Same issue

MisterTea commented 2 weeks ago

Someone reported this in the main repo. The fix is to reinstall xcode command line tools

mattgodbolt commented 1 week ago

Someone reported this in the main repo. The fix is to reinstall xcode command line tools

Similar issue here (maybe?):

try-native/external/crashpad/minidump/minidump_annotation_writer.cc
/tmp/et-20241018-36229-26n0l0/EternalTerminal-et-v6.2.9/external_imported/sentry-native/external/crashpad/minidump/minidump_misc_info_writer.cc:194:47: error: use of undeclared identifier '__MAC_OS_X_VERSION_MAX
_ALLOWED'
  194 |       AvailabilityVersionToMacOSVersionNumber(__MAC_OS_X_VERSION_MAX_ALLOWED));
      |                                               ^

How does one "reinstall xcode command line tools" ? brew doctor seems happy, how does one reinstall the CLI tools? (brew reinstall xcode type things didn't seem to wokrk)

dancrossnyc commented 1 week ago

Someone reported this in the main repo. The fix is to reinstall xcode command line tools

Similar issue here (maybe?):

try-native/external/crashpad/minidump/minidump_annotation_writer.cc
/tmp/et-20241018-36229-26n0l0/EternalTerminal-et-v6.2.9/external_imported/sentry-native/external/crashpad/minidump/minidump_misc_info_writer.cc:194:47: error: use of undeclared identifier '__MAC_OS_X_VERSION_MAX
_ALLOWED'
  194 |       AvailabilityVersionToMacOSVersionNumber(__MAC_OS_X_VERSION_MAX_ALLOWED));
      |                                               ^

How does one "reinstall xcode command line tools" ? brew doctor seems happy, how does one reinstall the CLI tools? (brew reinstall xcode type things didn't seem to wokrk)

It's kind of annoying, but the canonical way seems to be to delete them (e.g., just using rm -fr) and then reinstall using xcode-select. Something like:

rm -fr /Library/Developer/CommandLineTools
xcode-select --install

But! I found that didn't work for me; I ended up manually downloading and installing an xcode command tools DMG from https://developer.apple.com/download/all/, which corrected the problem.

mattgodbolt commented 1 week ago

Thanks @dancrossnyc . I don't have an apple developer account (and am not minded to make one) so I can't hit that second URL. I'm wary of randomly sudo rm -rf-ing files in a directory I don't own... is there a non-root-access/standard "please reinstall".

I'm not honestly sure how the developer tools made it in the first place: I only recall installing brew. Sorry for the noob questions: I mostly work on Linux and this mac thing is just a dumb terminal to get me to the "real" computer :)

mattgodbolt commented 1 week ago

I just bit the bullet, made an account and then installed 16.1 beta xcode tools. I get the same error :(. Maybe this is a new one?

I attach the full log now: 02.make.txt

dancrossnyc commented 1 week ago

Thanks @dancrossnyc . I don't have an apple developer account (and am not minded to make one) so I can't hit that second URL. I'm wary of randomly sudo rm -rf-ing files in a directory I don't own... is there a non-root-access/standard "please reinstall".

This I do not know, I'm afraid. I should note that a less destructive operation might be to just mv to a different name.

I'm not honestly sure how the developer tools made it in the first place: I only recall installing brew. Sorry for the noob questions: I mostly work on Linux and this mac thing is just a dumb terminal to get me to the "real" computer :)

Oh, I'm just chiming in from the side; I've got no skin in this game, I'm afraid. I'm guessing that brew installed the tools on your behalf.?

I just bit the bullet, made an account and then installed 16.1 beta xcode tools. I get the same error :(. Maybe this is a new one?

That looks like a different error? FWIW, the version I installed was 16.0 (the current release version). The error you are getting, __MAC_OS_X_VERSION_MAX_ALLOWED could be related to the tools package version, but I honestly don't know.

Sorry, I don't know if this is particularly helpful: I hope I didn't lead you astray!