Misterio77 / flavours

🎨💧 An easy to use base16 scheme manager that integrates with any workflow.
MIT License
506 stars 28 forks source link

Provide prebuilt binary #30

Closed heyhusen closed 3 years ago

heyhusen commented 3 years ago

Hi!

This PR will add prebuilt binary into latest release as a asset. I create this mainly for creating my own AUR package. I know there is an AUR package for flavours already, but I always prefer prebuilt binaries rather than build them by myself.

Currently only 3 platforms are provided: 64-bit Linux, 32-bit Linux & ARM64 Linux.

Here is the directory tree within each TAR archive created.

flavours-v0.4.2-x86_64-linux
├── completions
│   ├── bash
│   ├── elvish
│   ├── fish
│   ├── powershell
│   └── zsh
├── config.toml
├── flavours
├── LICENSE
└── README.md

Here is a working example: https://github.com/hapakaien/flavours/releases/tag/v0.4.2

Misterio77 commented 3 years ago

Hello!

Thanks a lot for the contribution. Automatically building a binary is definitely something on my wishlist for flavours haha.

This looks good for merging.

My only question is about how the release itself is created. It seems that this action automatically creates it? This happens when we push the git tag, right? I wonder if there's any way for the built assets to be added to the release after it was created (so i can add a nice title and changelog).

heyhusen commented 3 years ago

Yes, you're right. This build assets when we push git tag.

But releases are based on Git tags, so this will work on that too.

I've actually just made another release, and assets were added to it. Here is the release: https://github.com/hapakaien/flavours/releases/tag/v0.4.3

Another example is ncspot. I take inspiration from them haha.

Misterio77 commented 3 years ago

Looks awesome! Thanks a lot, merging this.