search

Misterio77 / flavours

🎨💧 An easy to use base16 scheme manager that integrates with any workflow.
MIT License
501 stars 29 forks source link

initial look at configuring source list #61

Closed Softsun2 closed 2 years ago

Softsun2 commented 2 years ago

Hello, as a preface, this is my first open source pr. I'm also more or less making a suggestion, I wouldn't use the code I've pushed as it's fairly crude (and it's my first time writing rust), its just to show what I'm suggesting can work. Maybe this should be a feature request rather than a pr?

I'm a big fan of this project. I was interested in being able to configure the source lists instead of having to do so manually in ~/.local/share/flavours/base16/sources.yaml after retrieving the default schemes and templates with flavours update all. I've only poked around the code briefly and slapped together a simple way of achieving this.

The Config struct now has four new fields:

I'm not familiar with the base16 scheme and template repos or how frequently prs are accepted. For the purpose of adding new schemes/templates maybe this solution is overkill if new themes/templates are easily added there. But I would like to be able to specify my own scheme/template lists that are used when I run flavours update all.

Again I'm not the most familiar with your design choice and source code. Is this a reasonable suggestion, does it conflict with any of your design choices? Is there a way of achieving this as is? Would you be interested in implementing this feature at all (I of course would be willing to help with this)?

Softsun2 commented 2 years ago

Regardless of if this idea is implemented, I'm going to use this fork once I finish the functionality I mentioned. I'll make a new pr when I feel it is ready.