search

Misterio77 / nix-colors

Modules and schemes to make theming with Nix awesome.
GNU General Public License v3.0
465 stars 38 forks source link

feat: add fish theme lib function #14

Closed uvNikita closed 2 years ago

Misterio77 commented 2 years ago

Hey! Thanks for the contribution!

I was wondering whether we could implement a base16-shell equivalent, instead of something specialized to fish. Does that make sense? I have a similar solution implemented here: https://git.sr.ht/~misterio/shellcolord

uvNikita commented 2 years ago

I'm by no means an expert in shell colors, so you might be right :)

The only reason i created a fish-specific plugin is because of this entry in base16-fish project https://github.com/tomyun/base16-fish#faq:

Why not just use base16-shell?

base16-shell is great for bash/zsh, but unable to support syntax highlighting colors in fish that ends up with incorrect coloring of texts typed in the prompt. base16-fish fixes this problem by explicitly setting color variables in native fish shell scripts. With that, no separate helper required in config.fish. No configuration file (.base16_theme) stored in your home directory. Theme switching commands (base16-*) are now fish functions that work more nicely with tab completetion.

Misterio77 commented 2 years ago

Hmm, the maintainer might be mistaken.

I use fish daily and the colors match perfectly (either terminal or base16-shell). Setting fish to named colors does the trick. image

I think it would be awesome if we can get a cross shell solution working

uvNikita commented 2 years ago

Closing since #19 was merged :tada: