Misterio77 / nix-colors

Modules and schemes to make theming with Nix awesome.
GNU General Public License v3.0
488 stars 42 forks source link

Documentation for setting GTK theme #45

Open AnotherRandomGitHubAccount opened 8 months ago

AnotherRandomGitHubAccount commented 8 months ago

I am trying to figure out how to use the gtk theme generation functionality, and how to make it set as the gtk theme. I've tried but can't figure out how to do this. a short example in the README.md would be very helpful. thanks

Kyesarri commented 8 months ago

I've set my GTK theme here: https://github.com/Kyesarri/nixos/blob/master/home/gtk/default.nix

Module is imported by the host machine: https://github.com/Kyesarri/nixos/blob/master/hosts/laptop/default.nix#L46

Colour scheme is set at the top of each host machine https://github.com/Kyesarri/nixos/blob/master/hosts/laptop/default.nix#L1-L3

and configured for home-manager and nixos on the following lines: https://github.com/Kyesarri/nixos/blob/master/hosts/laptop/default.nix#L69-L70

My code is messy, could be more functional but works for me. What have you tried so-far?

AnotherRandomGitHubAccount commented 8 months ago

after a while i got it to work. i forked the repo so I could change all background variants to base00... it would be nice if there were options other than just the materia theme. something like flat-remix or graphite would be nice

Kyesarri commented 8 months ago

after a while i got it to work. i forked the repo so I could change all background variants to base00... it would be nice if there were options other than just the materia theme. something like flat-remix or graphite would be nice

I believe that's out of the current teams scope, I'm sure they would be open to a PR if someone wanted to put the work in.

Misterio77 commented 7 months ago

Hey, contributed functions for different theme upstreams are very welcome!

Interface wise: the gtk-theme function's argument is an attrset so as to allow new arguments in the future. So feel free to add a upstream (or kind, or flavor, etc) argument (while falling back to materia by default) and implement your favorite theme :)

Misterio77 commented 7 months ago

Re documentation: I will look into adding a complete example for setting up GTK themes.

aspauldingcode commented 7 months ago

i forked the repo so I could change all background variants to base00...

I want to do the same. I just got this working thanks to @Kyesarri, although I went my own way about it.

in addition, I don't like how many applications are forced to use base02 instead of base00 (border of chromium for example). I am additionally curious if this background issue could be resolved. it should be base00 (like this neovim for example).

Could it be fixed without a fork?

Screenshot 2024-02-22 at 09 01 12 AM

Kyesarri commented 7 months ago

Thanks @aspauldingcode, glad to hear my spaghetti could help someone.

Interesting point about the colours used on some windows, from my digging around "02" should be used for selection backgrounds. Might be worthwhile looking into conformity between colour schemes.

https://codeberg.org/kye/nixos/src/branch/master/theme.css is what I base my theming off, I think Firefox may be the same for its window background but I'll have to check exactly which it is using.

@Misterio77 I've never forked a repository / sent a PR but I might take a look at what's being used across themes and try and get some further conformity.

AnotherRandomGitHubAccount commented 7 months ago

not everything, but all different kinds of backgrounds, titlebars, etc

On Fri, Feb 23, 2024, 4:22 AM kel @.***> wrote:

@AnotherRandomGitHubAccount https://github.com/AnotherRandomGitHubAccount - Did you change all background as per your post (including buttons, menu, text) or just the HDR?

— Reply to this email directly, view it on GitHub https://github.com/Misterio77/nix-colors/issues/45#issuecomment-1960608678, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2SDTW43CPOATAAFRGMFFCLYU7VONAVCNFSM6AAAAABCDGLKVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRQGYYDQNRXHA . You are receiving this because you were mentioned.Message ID: @.***>

--

Important: This email message, including any attachments, is intended solely for the addressee(s), and may contain information that is confidential or legally protected. Any use, disclosure, copying, printing, or distribution of the information contained herein by persons other than the designated addressee is unauthorized and may be unlawful. If you believe that you have received this email in error, please notify the sender immediately and delete this email and any attachments from your system and discard of any printout thereof.

Kyesarri commented 7 months ago

Added a PR: https://github.com/Misterio77/nix-colors/pull/48

I'd like to tackle more ideas on exposing spacing, roundness, opacity or even another theme but might be out of my wheelhouse currently. See how this progresses.

AnotherRandomGitHubAccount commented 7 months ago

Maybe this should be a separate project from nix-colors? As far as i know there is a gtk-nix module but it doesn't work so well and is quite dated

On Fri, Mar 1, 2024, 3:07 AM kel @.***> wrote:

Added a PR:

48 https://github.com/Misterio77/nix-colors/pull/48

I'd like to tackle more ideas on exposing spacing, roundness, opacity or even another theme but might be out of my wheelhouse currently. See how this progresses.

— Reply to this email directly, view it on GitHub https://github.com/Misterio77/nix-colors/issues/45#issuecomment-1972183002, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2SDTW2ESNLEWQXDM2A5ZBLYV7BDJAVCNFSM6AAAAABCDGLKVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZSGE4DGMBQGI . You are receiving this because you were mentioned.Message ID: @.***>

--

Important: This email message, including any attachments, is intended solely for the addressee(s), and may contain information that is confidential or legally protected. Any use, disclosure, copying, printing, or distribution of the information contained herein by persons other than the designated addressee is unauthorized and may be unlawful. If you believe that you have received this email in error, please notify the sender immediately and delete this email and any attachments from your system and discard of any printout thereof.

eureka-cpu commented 7 months ago

After trying to find the solution myself, I've gone ahead and opened a PR which just adds to the existing example in the contributed functions section of the README. Having a full guide on how you could potentially set GTK themes would be ideal, but having this would have saved me a few hours :p