search

Misterio77 / nix-colors

Modules and schemes to make theming with Nix awesome.
GNU General Public License v3.0
465 stars 38 forks source link

tt 0 11 wip #47

Open Misterio77 opened 4 months ago

Misterio77 commented 4 months ago

https://github.com/Misterio77/nix-colors/issues/44

Misterio77 commented 4 months ago

As mentioned in https://github.com/Misterio77/nix-colors/issues/44#issuecomment-1941262906:

The main problem is that there isn't really a pure nix yaml converter available. The one we're using is hackish and does not work with more complex (e.g. non-top level attributes) yaml, which the 0.11 spec now uses.

There's a few possibilities here:

  • Use IFD
    • Affects performance significantly
    • Requires changing our current colorSchemes.<scheme> interface to colorSchemes.<system>.<scheme>.
  • Pre-process and vendor JSON file(s) with the schemes
    • This was my approach before 2.0:
    • Will break the current feature that allows users to change the inputs.follows to switch nix-colors to different upstreams
  • Wait for https://github.com/NixOS/nix/pull/7340
    • Even if merged, will be an experimental feature for a while, so not ideal either
  • Ask tinted theming to include JSON versions of the schemes (?)
  • Somehow try to make the current fromYaml function work with nested keys