Misterio77 / nix-config

Personal nixos and home-manager configurations.
https://m7.rs/git/nix-config/
MIT License
719 stars 42 forks source link

Redundant directory creation in ephemeral-btrfs.nix #29

Open breezeight opened 6 months ago

breezeight commented 6 months ago

I was looking at the ephemeral-btrfs module. I see you ensure needed directories exists: https://github.com/Misterio77/nix-config/blob/ec4bd4983695521e8d1016093f3d092ffbe5ca6e/hosts/common/optional/ephemeral-btrfs.nix#L13-L14

But as far I understand the impermanence module included in optin-persistence.nix should https://github.com/Misterio77/nix-config/blob/ec4bd4983695521e8d1016093f3d092ffbe5ca6e/hosts/common/global/optin-persistence.nix#L11-L20

Does it make sense to ephemeral-btrfs.nix removing the above lines?