search

MistraModel / Mistra

Mistra - 1D model of the Marine Boundary Layer
GNU General Public License v2.0
3 stars 2 forks source link

mech/ and plots/ #8

Closed rs028 closed 2 years ago

rs028 commented 5 years ago

The directories src/mech/ and src/plots/ should probably be moved outside src/ to the main directory so that src/ contains only the fortran files.

pb866 commented 5 years ago

src/mech/ is debatable as the kpp files produce Fortran code that is part of the source code. So I can see the philosophy, why everything is stuffed in src. Plotting isn't really part of the model, so we could move this one up or even go one step further and have a different repo with plotting and analysis tools/scripts and move it to there.

I had just a quick look, is the namelists and param stuff new to version 9? I don't recall them from my Mistra times. We should probably move them to src as well. Not sure, whether you would see them related to the source code or as options/settings and let them, where they are.

Also, not directly related to this issue (I can open a new one, if necessary), but I just spotted that the folder paths in param are absolute and seem to be set for Josué's settings. Those paths should be made relative, so that the model is working for the base case without any adjustments. Or do you have the model running and it worked with the param file, @rs028?

rs028 commented 5 years ago

Yes, I see your point about src/mech.

I think namelists and param are new and they seem to be related to the model configuration/setup. so they should probably stay where they are or maybe be merged. But first we need to understand how they work (from a quick look it looks like they are briefly described in section 3 of the manual but not very clearly). Same for the relative/absolute paths thing.

I don't have the model running but we made some progress. I think the problem is in the $PATH settings on my workspace. I will post a solution as soon as I find it.

rs028 commented 2 years ago

PR #24 move the plotting script to a scripts/ directory in the main directory. Re the mech/ directory, see #16.