Misunderstood-Wookiee / Mules-and-Warehouses-Extended

Compliation and Maintenace for the famous mule mods.
Creative Commons Attribution 4.0 International
12 stars 12 forks source link

[Potential Bug]: XML parse errors in debuglog #125

Closed vlczero closed 3 years ago

vlczero commented 3 years ago

The commit e2f090649cbdc23605372a809df58eb06f6e7947 introduced some errors. From the debuglog:

[=ERROR=] 123376.38 extensions\Mules_and_Warehouses_Extended\aiscripts\station_mule.xml(422): Error while parsing expression: Operator expected
* Input: $targetIsResource and (not $targetIsProduct))
* Pos:                                               ^
[=ERROR=] 123376.38 extensions\Mules_and_Warehouses_Extended\aiscripts\station_mule.xml(423): Error while parsing expression: Operator expected
* Input: $(not targetIsResource) and ($targetIsProduct))
* Pos:    ^
[=ERROR=] 123376.38 extensions\Mules_and_Warehouses_Extended\aiscripts\station_mule.xml(425): Error while parsing expression: Operator expected
* Input: $targetIsWare and (not $targetIsResource) and (not $targetIsProduct))
* Pos:   

looks like double ))

Misunderstood-Wookiee commented 3 years ago

Looks like it won't effect anything but debug, all those lines are debug lines it seems.

On Sun, 9 May 2021, 4:44 am vlczero, @.***> wrote:

Assigned #125 https://github.com/Misunderstood-Wookiee/Mules-and-Warehouses-Extended/issues/125 to @Misunderstood-Wookiee https://github.com/Misunderstood-Wookiee.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Misunderstood-Wookiee/Mules-and-Warehouses-Extended/issues/125#event-4708521700, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFH3SZ7MHTL4R464K7Z4HGLTMWA7RANCNFSM44NZJILA .

vlczero commented 3 years ago

Yea thought so, Still learning x4 modding and what counts as not loading the whole mod. Had that problem with a typo in my own mod I'm making. Looks like bhayden53 already fixed it in efc7cb0e9f61f644e66416f0c679d127d9037472

Closing this then. Thanks for the mod!

Misunderstood-Wookiee commented 3 years ago

Ah yes, and thank you for pointing this out too as it remind me that there is a localisation pull request ill have too merge and fix the new param in the commit that fixes this issue, as the localisation PR doesn't account for this new parameter.

The fix you mentioned is available in the development branch as if speaking I will most likely merge the localisation feature update and tidy up for a public release today

On Sun, 9 May 2021, 5:49 am vlczero, @.***> wrote:

Yea thought so, Still learning x4 modding and what counts as not loading the whole mod. Had that problem with a typo in my own mod I'm making. Looks like bhayden53 already fixed it in efc7cb0 https://github.com/Misunderstood-Wookiee/Mules-and-Warehouses-Extended/commit/efc7cb0e9f61f644e66416f0c679d127d9037472

Closing this then. Thanks for the mod!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Misunderstood-Wookiee/Mules-and-Warehouses-Extended/issues/125#issuecomment-835488109, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFH3SZZGXNLGB4LMPNAFTV3TMWITHANCNFSM44NZJILA .

bhayden53 commented 3 years ago

I noticed this as well, I believe I fixed it in my local code but not sure if it made it into an actual pull request