MitMaro / git-interactive-rebase-tool

Native cross-platform full feature terminal-based sequence editor for git interactive rebase.
https://gitrebasetool.mitmaro.ca/
GNU General Public License v3.0
1.59k stars 48 forks source link

Commit information for renamed files in reverse order #925

Closed StephenGregory closed 4 months ago

StephenGregory commented 4 months ago

When pressing "c" to view commit information, I see:

renamed: foo/bar.java -> buzz/bar.java

However, bar.java moved from buzz to foo.

git log --stat 1234 displays:

{buzz => foo}/bar.java      | 0

Version: 2.4.0

ccoVeille commented 4 months ago

I'm using the tool for more than a year, if not more, and I had never noticed the c command.

You made my day @StephenGregory

MitMaro commented 4 months ago

Thanks for the bug report @StephenGregory !

Looks like the mistake is here https://github.com/MitMaro/git-interactive-rebase-tool/blob/2d458aa97cb9b2ba9cc59a5f11b6ba7a9c931f5b/src/modules/show_commit/util.rs#L83-L106

I would like to say that was due to some refactoring I did with the recent release, but it's existed for around 5 years. 😅

Thankfully it should be an easy fix, and I can push out a release shortly after.

ccoVeille commented 4 months ago

Do we win something ? like the one who find the oldest bug gets a laptop sticker?

MitMaro commented 4 months ago

Interestingly enough, I'm pretty sure @StephenGregory has a sticker on a laptop that I probably gave him, though that was years ago.

@ccoVeille , if you were geographically closer, I would gladly provide a sticker for a community group I help run. :D

ccoVeille commented 4 months ago

France here, how far are you?

Canada apparently 🍁 🇨🇦 😅