Open brainard52 opened 3 years ago
I'm working on a patch to this, however, there's a bug on the wiki that makes it awkward.
There's currently a bug (or perhaps intentional, it's unclear) which restricts the API to a maximum offset of 5000. https://runescape.wiki/w/Forum:Wiki_Property_Search_doesnt_go_above_5000_items Beyond this point it just lists the first page infinitely.
This is fine for Equipable_items because it's only 3000 items, but there are lists that go far beyond 5000, such as "Members' items".
This works as expected, returning results from the offset of 5000. https://oldschool.runescape.wiki/api.php?action=ask&query=[[category:Members%27+items]]|offset=5000 However this returns results from the beginning. https://oldschool.runescape.wiki/api.php?action=ask&query=[[category:Members%27+items]]|offset=5001
I'm looking into alternative ways, but for now we may have to put a hard limit at 5000.
I'm looking into alternative ways, but for now we may have to put a hard limit at 5000.
The wiki folks are quite accommodating. Have you tried reaching out to them about the bug? I've been quite successful in communicating with them through Discord.
I'm looking into alternative ways, but for now we may have to put a hard limit at 5000.
The wiki folks are quite accommodating. Have you tried reaching out to them about the bug? I've been quite successful in communicating with them through Discord.
To be honest I just don't have the effort nor people skills to commune with them haha.
Also from the thread I linked to, this was the response (Back in 2016):
In case anyone was wondering, the response I got was that staff think it's expected behaviour, but aren't completely sure. Others I've spoken to don't believe it was always this way, but rather something introduced relatively recently. No one has spotted any documentation to suggest it's expected. Either way, Wikia hope to complete an upgrade to SMW in August, and hope this will magically resolve itself. If not, they'll investigate the bug once the upgrade is complete.
This seems to be a fairly dead project anyway, the author is inactive.
This shouldn't be too hard there is a property returned called query-continue-offset
which you can pass into a subsequent query and then it is just a case of combining the queries together. See: https://www.semantic-mediawiki.org/wiki/Help:API:askargs
I do wonder about the other performance impacts with a large number of bank tags I don't know if it was designed to work with this amount of items in a tag, but I guess I can give it a go and see, this will rely on async being implemented first (#4) currently the plugin limits queries to 2500 items as I found there was no noticeable stutter at this amount and it would be enough for most use cases.
This shouldn't be too hard there is a property returned called
query-continue-offset
which you can pass into a subsequent query and then it is just a case of combining the queries together. See: https://www.semantic-mediawiki.org/wiki/Help:API:askargsI do wonder about the other performance impacts with a large number of bank tags I don't know if it was designed to work with this amount of items in a tag, but I guess I can give it a go and see, this will rely on async being implemented first (#4) currently the plugin limits queries to 2500 items as I found there was no noticeable stutter at this amount and it would be enough for most use cases.
I have connections to high up wiki technical staff if you want me to reach out and ask anything specific.
https://oldschool.runescape.wiki/w/Category:Equipable_items
There are almost 3000 items in that category, so it's possible that it's just too big. The category is also paginated, so it could be that it functions a little differently than normal. I'm not entirely sure what's happening, though.