search

MitchTalmadge / AMP-dockerized

CubeCoders AMP in a Docker Image. Easily create game servers for games like Minecraft, GMod, TF2, Factorio, and StarBound!
https://hub.docker.com/r/mitchtalmadge/amp-dockerized
Other
91 stars 22 forks source link

Adapt Dockerfile and build.yml to enable arm64 builds #140

Closed rekonnected closed 1 year ago

rekonnected commented 1 year ago

The dockerfile is what makes the arm64 image work as long as you build it with --platform linux/amd64,linux/arm64 (if building manually).

The singular change in build.yml tells GH to make both automatically.

I might not have done this in the absolute best/most efficient way, but I think it's pretty clean and it works from my testing.

rekonnected commented 1 year ago

@MitchTalmadge have you had a chance to take a look at this?

rekonnected commented 1 year ago

@MitchTalmadge It's been 6 months since this was submitted with no acknowledgement or anything, would you be able to look at this please?

MitchTalmadge commented 1 year ago

This looks great!! ❤️ I really appreciate the time and effort you put into this, and I sincerely apologize for never getting back to you on it. See #162. I'm merging it into staging and we'll see how it goes!

MitchTalmadge commented 1 year ago

The build succeeded! The docker push did not, though. :P I need to tweak the script to handle the different architectures more appropriately.

rekonnected commented 1 year ago

Totally understood, no worries. Was just worried the project got completely abandoned which would have been unfortunate given CC's insistence that the whole thing "can't" run in docker alone (which you're sadly very familiar with). Really happy the build itself worked though, this was my first foray into docker image creation/management and I just wanted it to run on an Oracle virtual machine 😅