search

Mitcheljager / svelte-confetti

Confetti in Svelte! Celebrate things with some extra flair. Animates using just HTML and CSS meaning it can work with SSR in SvelteKit!
https://mitcheljager.github.io/svelte-confetti/
265 stars 10 forks source link

Fix Syntax of String Returned by `getColor` #10

Closed mstachowiak closed 9 months ago

mstachowiak commented 9 months ago

The getColor function returns an hsl() color calculation but doesn't include a closing ) to the function call. This somehow works in Svelte 4 but starts breaking with Svelte 5.

This pull request can be reviewed on GitContext.com

hichemfantar commented 9 months ago

@Mitcheljager could it be because svelte 5 changes the css parsing library css-tree to an inhouse solution. It could be that css-tree used to auto fix this problem which could explain why it breaks now.