search

Mitcheljager / svelte-confetti

Confetti in Svelte! Celebrate things with some extra flair. Animates using just HTML and CSS meaning it can work with SSR in SvelteKit!
https://mitcheljager.github.io/svelte-confetti/
265 stars 10 forks source link

Create Sub Package or Upgrade For Svelte5 #11

Closed sansjack closed 3 months ago

sansjack commented 3 months ago

Just wondering if we could get a svelte5 update or sub package for this? When using svelte5 i am getting the following dependency error:

npm error While resolving: monitro@0.0.1
npm error Found: svelte@5.0.0-next.192
npm error node_modules/svelte
npm error   dev svelte@"^5.0.0-next.191" from the root project
npm error
npm error Could not resolve dependency:
npm error peer svelte@"^4.0.0 || ^5.0.0" from svelte-confetti@2.0.1
npm error node_modules/svelte-confetti
npm error   svelte-confetti@"*" from the root project
Mitcheljager commented 3 months ago

Version 1.x is reserved for Svelte 4, and version 2.x is for Svelte 5 going forward. There's still some annoying dependencies, but I think I've managed to suppress them. Using version 2.1.1 and above should work. I've also updated the docs to reflect the changes. Please let me know if it all works as expected!

dyc3 commented 3 months ago

It would be great to mention that in the readme and the docs website.

Mitcheljager commented 3 months ago

It is mentioned in the docs image

I'll update the readme too

sansjack commented 3 months ago

This is much appreciated, Amazing work btw 😃

sansjack commented 3 months ago

Version 1.x is reserved for Svelte 4, and version 2.x is for Svelte 5 going forward. There's still some annoying dependencies, but I think I've managed to suppress them. Using version 2.1.1 and above should work. I've also updated the docs to reflect the changes. Please let me know if it all works as expected!

seems like im getting this error when doing npm install svelte-confetti@^2.1.1 --save-dev

npm error Found: svelte@5.0.0-next.192
npm error node_modules/svelte
npm error   dev svelte@"^5.0.0-next.192" from the root project
npm error
npm error Could not resolve dependency:
npm error peer svelte@"^5.0.0" from svelte-confetti@2.1.1
npm error node_modules/svelte-confetti
npm error   dev svelte-confetti@"^2.1.1" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
dyc3 commented 3 months ago

FYI this is what I'm seeing on https://mitcheljager.github.io/svelte-confetti/

image

Mitcheljager commented 3 months ago

@dyc3 Ah sorry, try again

dyc3 commented 3 months ago

Yup, I see it now. Thanks!