MitchellMarkGeorge / TabButler

A tab manager at your service.
https://tabbutler.netlify.app/
MIT License
43 stars 5 forks source link

Refactor Search compoenent data retreival for tab data and actions #29

Closed MitchellMarkGeorge closed 2 years ago

MitchellMarkGeorge commented 2 years ago

Is your feature request related to a problem? Please describe. If you look at how the tab data and actions are fed into the modal currently, you might notice that the current implementation does not allow the React UI to handle errors in the data fetching. This should be solved by moving this logic to the Search component. As simple as this may seem, this holds some other implications as well for some of the event listeners we have (like the page visibility listener). Listeners like these would need to be moved to the Search component. Right now if the data retrieval fails, the search component will be shown blank with no info for the user.

Describe the solution you'd like See above (if you need more clarification, please reach out to me)

Describe alternatives you've considered N/A

Additional context This will be moved to a priority for beta so we can get the error handling going. This might be large than expected though, so if it is not done in time for beta, we might move it over to another release during the beta window

MitchellMarkGeorge commented 2 years ago

Due to some technical difficulties, this will probably be pushed back so more pressing things can be worked on. Error handling will currently be handled using a prop passed to the Search component.

MitchellMarkGeorge commented 2 years ago

I will probably take some notes from the work I have currently done and update the component

MitchellMarkGeorge commented 2 years ago

I was able to do this in #46 and might merge it in a few days

MitchellMarkGeorge commented 2 years ago

Moving this to 1.0