MitchellMarkGeorge / TabButler

A tab manager at your service.
https://tabbutler.netlify.app/
MIT License
43 stars 5 forks source link

Search component refactor #46

Closed MitchellMarkGeorge closed 2 years ago

MitchellMarkGeorge commented 2 years ago

Description

Closes #29 This PR is a major refactor of the Search component.

Type of changes made

What changes were made

This was done mostly with 1.0 in mind. With the new UI to be implemented, the current implementation was just not scalable enough and would require an enormous amount of workarounds to get working (if you look at the current content.ts file, you might already be able to see some of these "solutions" have been implemented). The refactor allowed more code to be moved directly to the Search component, where it is closer to the UI.

Here is a list of the fixes and refactoring that took place:

I might have missed some changes so please take a look at the code. This is definitely not needed for the beta launch, but it is critical for scaling to 1.0, and the faster we integrate these changes, the easier it will be going forward.

MitchellMarkGeorge commented 2 years ago

@mohitkyadav @andrei-g-git @VladBrok Feel free to review the changes. For some reason, it wasn't letting me ad you gys as reveiwers.

VladBrok commented 2 years ago

Looks awesome!