MitchellMarkGeorge / TabButler

A tab manager at your service.
https://tabbutler.netlify.app/
MIT License
43 stars 5 forks source link

Extension stops working after update #54

Closed MitchellMarkGeorge closed 2 years ago

MitchellMarkGeorge commented 2 years ago

Describe the bug After the extension is updated, the extension no longer works on all the open pages. This is something that I experienced in development but did not think would affect production. This is because on update, the content script in those open tabs are "cut off" from the extension, and when you try to trigger it after the update, there is no content script to trigger the modal.

To Reproduce Steps to reproduce the behavior:

  1. Have the extension installed
  2. Allow it to update
  3. Try and use it. The Search modal should not show up

Expected behavior The extension should work after updates

Screenshots

Screen Shot 2022-07-24 at 9 59 18 AM

Platform Info (please complete the following information):

Additional context The solution here is to reinject the content script on updates as well and edit the content script to remove the previous tab-butler-modal-root element if found.

MitchellMarkGeorge commented 2 years ago

The only problem with this is that the old content script will still be in the page and will not be fully unmounted (listeners might still be active). This will not be much of an issue once #46 is implemented