search

MitchellSternke / SuperMarioBros-C

An attempt to translate the original Super Mario Bros. for the NES to readable C/C++
625 stars 70 forks source link

Add settings window to modify various things. #6

Open Mario0051 opened 6 years ago

Mario0051 commented 6 years ago

EDIT: Figured out there is a Constants.hpp file so it should be fairly simple to make a settings window that modifies the numbers within. A settings window would be able useful to people to make it easier to change the palette colors, sampling rate, frame-rate, etc. Obviously it should work fairly straightforward for casual people to just open the game and play without changing any settings. (This is a suggestion, but it's not really needed for most people)

MitchellSternke commented 5 years ago

Hi, thanks for the suggestion.

I agree it would be nice to have some way to configure settings, whether it be with a GUI like you suggest or maybe some kind of configuration file. It's definitely on the to-do list, but not a high priority right now 😃

I think for now this project is more of a fun thing for developers to play around with than something that is close to releasable, so changing settings can be done with the code. But if this project evolves I'm sure something like this will be needed.

MitchellSternke commented 5 years ago

@Mario3264 I have added a config file in the latest commit (76e0824d4c738c0bbd026542b482df4ac8c109bc). This is not quite a settings window, but should allow you to change some of the options that were in Constants.hpp easily without recompiling the game. Please take a look at README.md for instructions on how to use it.

Mario0051 commented 5 years ago

Yep, seems to work good; Do you plan on adding frame-rate configuration in the config file?

MitchellSternke commented 5 years ago

@Mario3264 I have added configuration for the frame rate in this commit: 2723ad798940e42b11640890bc00c16cf6ce7017

Anonymous3-a commented 9 months ago

This seems to be solved, please close.