Mithion / Mana-And-Artifice

Ars Magica 3: Mana and Artifice
51 stars 6 forks source link

Ritual of Locating only works for Biomes #822

Open Slickson77 opened 2 weeks ago

Slickson77 commented 2 weeks ago

Describe the bug Trying to create a Thaumaturgic Compass for anything that is a structure will have the ritual fail immediately with a message that "The Ritual wasn't able to find it's target within a reasonable distance"

To Reproduce Steps to reproduce the behavior:

  1. Perform the ritual of location using ANY structure Thaumaturgic Link
  2. See error

Expected behavior man ... I'd like to be able to find structures using the magic compass

Version Information (please complete the following information):

Additional context My guess is that this broke when you ported from 1.18.2. The older version had one locate command for both biomes and structures (I think). In 1.20.1 this was switched so that biomes use "/locate biome" and structures use "/locate structure".

Mithion commented 2 weeks ago

Just tried it in dev, worked fine. Several times in a row, using different structures, both modded and non. Nothing broke in the update.

I attempted a minor change in methodology when resolving the holder set, which still finds structures in my dev instance so maybe it will work for this now too. Honestly I haven't seen this at all yet. No idea why it isn't working. We'll see if next update is any better.

Slickson77 commented 1 week ago

No idea if this helps at all ... but in my line of work, more info is always better!

MoM server crashed while running a locate ritual for a biome after initiation in about 5-10 sec. I was the only one on the server at the moment. crash-2024-06-28_11.08.30-server.txt

Vallen was able to log in and run a command manually without issue

image