search

MithrilJS / docs

Source code for Mithril's documentation site
https://mithril.js.org
MIT License
1 stars 4 forks source link

Fix `m.request` example on home page #14

Open StephanHoyer opened 1 year ago

StephanHoyer commented 1 year ago

The last Example does not work, I think because of CORS. We should fix that.

DerFichtl commented 1 year ago

rem-rest-api.herokuapp.com is gone. All ajax examples don't work anymore.

dead-claudia commented 1 year ago

Can confirm the endpoint is down.

pygy commented 1 year ago

Thanks for the heads up, it was discussed in the chat, I hadn't seen this issue...

I think Heroku retired the free tier, and Leo understandably let REM disappear.

A possible solution would be to emulate the API using a service worker. If anyone feels like writing that it would be most welcome.

pygy commented 1 year ago

There's also a dead link to brick.mozilla.io in .//docs/hyperscript.md

I'm removing these links from the WIP docs for the linter to pass, and mark this bug as critical so that we don't forget fixing it before the release.

Oneted11 commented 1 year ago

In the simple application example it refers to "bin/app.js" which webpack right now generates a "bin/main.js"

I'm halfway through but I am currently using https://jsonplaceholder.typicode.com/users which works for the beginnings but I will probably get issues with POST and such...

It does require changing the user display to fullname instead of first-name + " "+lastname

dead-claudia commented 1 year ago

@pygy Seems that project was archived years ago: https://github.com/mozbrick/brick (though oddly its subrepos weren't).

EtiamNullam commented 1 year ago

Would it be fine to use some free public fake API like https://jsonplaceholder.typicode.com for now? Broken example on the main page surely isn't good for bringing new users.