search

MithrilJS / mithril-node-render

Use mithril views to render server side
MIT License
210 stars 44 forks source link

Add prettier and fix errors #88

Closed reubano closed 4 years ago

reubano commented 5 years ago
StephanHoyer commented 5 years ago

Thanks for the PR.

Would you mind looking at the failing tests?

I also dislike the double-quotes and the semis. I'm so used to standard right now. But I think your version is more align with the mithril core, so I think I'm ok with it.

reubano commented 5 years ago

Think I've fixed them. I actually have similar preferences as yours, but didn't know about standard and that it's basically a prettier alternative. I won't be offended if you switch back to it, or update the config.

StephanHoyer commented 5 years ago

Sorry for the delay.

Made some inline comments.

StephanHoyer commented 4 years ago

fixed with f18c225 thanks for your work, tho