Html converter fails with html comments

MithrilJS / mithril.js

A JavaScript Framework for Building Brilliant Applications

https://mithril.js.org

MIT License

14.02k stars 925 forks source link

Html converter fails with html comments #195

Closed caneruguz closed 10 years ago

caneruguz commented 10 years ago

Using the online template converter, if there is an HTML comment in the text it will not do the conversion. The error is: Uncaught TypeError: Cannot read property '0' of undefined lhorie.github.io/mithril/tools/template-converter.js:17

I think it's expecting the comment to be a tag and can't get attributes for it.

http://lhorie.github.io/mithril/tools/template-converter.html

lhorie commented 10 years ago

This bug is fixed in origin/next and will be online w/ v0.1.20