Open ACXgit opened 4 years ago
Found the issue:
#!/
, so it has to update the route.I feel the issue may be mitigated in two parts:
requestAnimationFrame
once for each root rather than once for all roots, and just use the array of scheduled roots to avoid double-scheduling roots. (It's worth noting no user code can run between animation frame callbacks, and microtasks are delayed until after paint, so this change would likely not be user-breaking.)
Errors inside components do not reach
window.onerror
event handler while using the Mithril router, mounting components withm.route
. Instead they do when the component is mounted withm.mount
.This didn't happen in 1.x.
Mithril version: 2.0.4
Browser and OS: Firefox 81 64bit, Windows 10
Code
[flems]
m.route
with Mithril 1.1.7, working as expected[flems]
m.route
with Mithril 2.0.4, not forwarding[flems]
m.mount
with Mithril 2.0.4, working as expectedContext
Without errors being forwarded to
window.onerror
it's impossible to catch them globally and log them, i.e. to an application monitoring and error tracking platform like Sentry.