Closed pygy closed 2 years ago
@pygy You have a status update on this? We got another person reporting the same issue: #32
@pygy Status update? #35 is reporting this very thing.
Oh hai Claudia, I'll take a look hopefully this evening
Yes, travis.org
is about to go poof by June 16th apparently, they suggest one migrates to travis.com
which, right off the bat tries by default to get write permission to all of one's repos (it can be worked around easily, but it doesn't inspire confidence).
I had read that the new owner was shady, and this confirmed my impression, hence the move to GH actions.
I'll take your suggestions into account... This is in a WIP state obviously, I'm making progress in a dedicated branch over at https://github.com/pygy/ospec/tree/actions-tests to avoid spamming the gitter log.
I had read that the new owner was shady, and this confirmed my impression, hence the move to GH actions.
@pygy On that note, follow up across all our repos once you get this one in shape.
@isiahmeadows We use the previous stable release to run the current test suite, but this won't work for CI on Windows (because the ESM tests won't work there with the stable version), so I propose we release, on a distinct NPM channel, one version that uses itself as a test harness, then release a stable release that relies on the aforementioned (and bump the devDep immediately after publishing so that future versions once again can rely on the previous stable release).
Edit, actually, no need to do a custom release, I can have v4.1.2 depend on a git hash rather than the NPM package
On that note, follow up across all our repos once you get this one in shape.
Gotcha
Alternative: I pull your patch and verify it locally. I can patch with a quick hack easily enough - that's how I'm getting by with Mithril.
This is another take on #28, plus some cleanup.
We add the
file:
, a dev dependency oncli-shims
to get the exact samenode_modules/.bin
shims as NPM.I also removed the 'old style count' from the log, and the corresponding infrastructure.
I still have to fix the release instructions and the change log.
How Has This Been Tested?
I tried it the best I could from macOS (by using the shims there too, it runs the
bin/sh
one), but this needs to be tested in Windows before it is merged.Types of changes
Checklist: