search

MithrilJS / ospec

Noiseless testing framework
MIT License
48 stars 13 forks source link

update glob to v9 #69

Closed chromy closed 2 months ago

chromy commented 2 months ago

Description

Update glob to v9

Motivation and Context

Installing ospec currently shows the following warnings:

 WARN  deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
 WARN  deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.

See also:

How Has This Been Tested?

Types of changes

Checklist:

dead-claudia commented 2 months ago

Have you tested this yet? I see the box isn't checked in the initial comment.

chromy commented 2 months ago

I had not - but I have now and I did discover and fix an issue, thanks! :)

[snip]
...took 524 ms
[ metadata + v5 API + esm + pnpm]
...took 730 ms
[ metadata + v5 API + esm + yarn]
...took 636 ms
––––––
All 10333 assertions passed

log-after.txt log-before.txt

dead-claudia commented 2 months ago

@chromy Did you attach the right log file? The "before" file doesn't show failures?

dead-claudia commented 2 months ago

Ignore the CI run. https://github.com/MithrilJS/ospec/issues/70

chromy commented 2 months ago

@dead-claudia Ah by before I meant running the tests at HEAD (610b2c3d) and after was with my latest changes (bfcc9f37), sorry that was not clear.

dead-claudia commented 2 months ago

@dead-claudia Ah by before I meant running the tests at HEAD (610b2c3) and after was with my latest changes (bfcc9f3), sorry that was not clear.

@chromy Oh, okay. That makes more sense.