search

MitjaNemec / Kicad_action_plugins

Kicad action plugins
415 stars 62 forks source link

replicate layout not working 5.99_test #137

Closed sqrtmo closed 3 years ago

sqrtmo commented 3 years ago

Hello, I am getting strange message when try to execute replicate layout plugin.

Screenshot 2021-07-30 at 15 35 41

Attaching replicate layout log file. replicate_layout.log `Application: KiCad PCB Editor

Version: (5.99.0-10369-gb59bf064b4), release build

Libraries: wxWidgets 3.0.4 libcurl/7.64.1 SecureTransport (LibreSSL/2.8.3) zlib/1.2.11 nghttp2/1.41.0

Platform: macOS Version 10.16 (Build 20G80), 64 bit, Little endian, wxMac

Build Info: Date: Apr 20 2021 20:24:27 wxWidgets: 3.0.4 (wchar_t,STL containers,compatible with 2.8) Boost: 1.75.0 OCC: 7.5.1 Curl: 7.54.0 ngspice: 31 Compiler: Clang 10.0.1 with C++ ABI 1002

Build settings: KICAD_SCRIPTING=ON KICAD_SCRIPTING_MODULES=ON KICAD_SCRIPTING_PYTHON3=OFF KICAD_SCRIPTING_WXPYTHON=ON KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF KICAD_SCRIPTING_ACTION_MENU=ON KICAD_USE_OCC=ON KICAD_SPICE=ON `

Hope I am not making some stupid mistake.

Thanks in advance!

MitjaNemec commented 3 years ago

Thanks for the feedback

Well I obviously still have a lot of python to learn. The cryptic message is because I assumed an LookupError exception could happen only when I raise it within the plugin backend. Obviously I was wrong. Maybe I should write my own exceptions for the faults that I handle, so that I don't use python's default exceptions.

Anyhow, I've added instrumentation, and I'd like if you can update the plugin and recreate the issue. The .log file should have some additional info.

sqrtmo commented 3 years ago

replicate_layout.log

Thanks a lot!

MitjaNemec commented 3 years ago

I think, I've found a bug. The fix was pushed, so please try again and report the results back.

Thanks for testing

sqrtmo commented 3 years ago

replicate_layout.log

Hmm, I am getting error again.

MitjaNemec commented 3 years ago

Can you share the project? it would speed up the debugging. But if you can't, Then I'll have to ask you for patience, as we'll need to do this back and fort a couple of times

sqrtmo commented 3 years ago

blueBoard_v2.zip

Yep, now the problem appears if I try to replicate TMC sheet, but If I delete all other sheets and then replicate TMC block it is working.

Thanks a lot!

MitjaNemec commented 3 years ago

OK, I've found a bug. It was the UUID handling (the 5.1 compatibility fix striped leading or trailing zeros)

Please update the plugin, and try it on your end (I check only on MSW platform)

sqrtmo commented 3 years ago

OK, it seems that it is working now. Tested on macOS.

Thanks a lot!!!

MitjaNemec commented 3 years ago

Thanks for reporting and testing