search

MitjaNemec / Kicad_action_plugins

Kicad action plugins
413 stars 62 forks source link

archive_project doesn't archive the page layout description file #53

Closed Sembazuru closed 4 years ago

Sembazuru commented 5 years ago

As the title says, a configured page layout file isn't archived so does not become portable.

I'd like the archive_project to copy the defined page layout file for both schematic and pcb to the project folder and then redirect the path to the project directory.

The setting for the page layout for both EEschema and PCBNew is in the project .pro file, so that might make this difficult...

MitjaNemec commented 5 years ago

Thanks for reporting it (I think it was mentioned before either on kicad-info forum or within some issue here on GitHub) so that it will not be forgotten.

As you said this is probably not doable as KiCad manager might rewrite any changes that are made from within the pcbnew. I'll try this out and see where it gets me. If you could supply a test project along with page layout description this would be even better.

MitjaNemec commented 4 years ago

@Sembazuru, I've pushed an implementation of worksheet archivation in the archive_worksheet branch. It works on windows and if you can test it on any other OS I'd appreciate it.

Sembazuru commented 4 years ago

Unfortunately for testing, I only have access to Windows as well.

On Wed, Sep 4, 2019 at 8:44 AM Mitja Nemec notifications@github.com wrote:

@Sembazuru https://github.com/Sembazuru, I've pushed an implementation of worksheet archivation in the archive_worksheet branch. It works on windows and if you can test it on any other OS I'd appreciate it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MitjaNemec/Kicad_action_plugins/issues/53?email_source=notifications&email_token=ABCDEJRNK3W665753DH46L3QH6UR5A5CNFSM4HR37Y5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD53N4QY#issuecomment-527883843, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCDEJQEWAKN45U7KUHUMMLQH6UR5ANCNFSM4HR37Y5A .

MitjaNemec commented 4 years ago

Merged to master