Replicate layout: If run before saving all sheets in eeschema gives criptic message.

MitjaNemec / Kicad_action_plugins

Kicad action plugins

414 stars 62 forks source link

Replicate layout: If run before saving all sheets in eeschema gives criptic message. #63

Open dinoghi opened 5 years ago

dinoghi commented 5 years ago

To reproduce the issue: -Create a hierarchical sheet with some components in it (assign also footprints), don't save it. -Copy and paste the hierarchical sheet (don't save). Syncrhronize pcb (F8) Use the script on one of the newly created sheets. An error pop up is shown with the message "u'5D76A583" and the "ok" button (that seems to be the unique timestamp of the new sheet with the components to be placed).

Tested on master branch kicad, Cheers, Dino.

dinoghi commented 5 years ago

Also verified on kicad stable 5.1.2 (Linux)

MitjaNemec commented 5 years ago

Yes the plugin has to read .sch files in order to get additional info not available from the .kicad_pcb. As there is currently no mechanism to check if the schematics was saved before running the plugin, there is not much that I can do. Maybe I could make the error message more user friendly. I'd appreciate the replicate_layout.log file to see where and how it fails. Thanks for reporting it though.

dinoghi commented 5 years ago

Yes, having a more descriptive error popup is a good solution (like "unable to open file xxx.sch: please check the sheet file has been saved in eeschema" or something similar that helps the user to understand that he missed the "save" step) ...and here is the log file.

replicate_layout.log

Cheers, Dino.