search

MitjaNemec / Kicad_action_plugins

Kicad action plugins
413 stars 62 forks source link

Broken dialog in PCBnew #7

Closed herostrat closed 6 years ago

herostrat commented 6 years ago

Thanks for the plugins!

I am using the kicad 5rc2 It seems that the plugin dialog is broken here.

The dialog when executing: grafik

Clicking the radiobuttons does not change that both are ticked. I can however switch to the circular window and back. grafik

Observation 1: I can input the linear data. If I execute the script, it is interpreted as circular data (x offset being the radius and y offset the angle)

Observation 2: Circular execution is working as expected

My guess is that in the dialog initialization something is broken. With a quick lock in the code didn't find the reason.

If you need any more informations or pics just let me know.

Thanks a lot!

MitjaNemec commented 6 years ago

Hi,

Thanks for reporting.

I'll not be able to start fixing it until 6.6.2018.

In the mean time, can you tell me what OS did you run this on?

And if you are in a hurry, you could try any commit from Feb 2nd. I was changin GUI to solve an issue in MacOS and it might trigger a regression in other oses.

On 29 May 2018 23:40:24 CEST, herostrat notifications@github.com wrote:

Thanks for the plugins!

I am using the kicad 5rc2 It seems that the plugin dialog is broken here.

The dialog when executing: grafik

Clicking the radiobuttons does not change that both are ticked. I can however switch to the circular window and back. grafik

Observation 1: I can input the linear data. If I execute the script, it is interpreted as circular data (x offset being the radius and y offset the angle)

Observation 2: Circular execution is working as expected

My guess is that in the dialog initialization something is broken. With a quick lock in the code didn't find the reason.

If you need any more informations or pics just let me know.

Thanks a lot!

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/MitjaNemec/Kicad_action_plugins/issues/7

herostrat commented 6 years ago

Hey, thanks for the fast answer.

I am running KUbuntu 17.10 and KiCad5r2

Your guess is true, it seems the GUI fix triggered the regression. I testes df8c6fb6240bae4f50a3ac327d447a8297917517 and this version worked flawlessly.

Let me know if you want me to test your changes, if you find time for it :)

spyro2 commented 6 years ago

I had the same issue, also on Ubuntu. I knobbled the script to always work in linear coordinates.

It looks like in the example videos of the script there is an additional box around the radio buttons - I do not see this on the current version on Ubuntu.

MitjaNemec commented 6 years ago

@herostrat thanks for the testing. I really appreciate it. Keep in mind there were a few bugs since that commit that were fixed. You might get by only taking action_replicate_layout.py from that revision.

@spyro2 you have sharp eyes. As I don't change the documentation with each new revision, the video/animation still shows older revision.

Anyhow it seems that implementation with wxRadioButton has a problem in Ubuntu (or maybe even in other Linux distributions) and implementation with wxRadioBox has a problem on MacOS. Both implementations work in Win7 (and hopefully even 8, 8.1 and 10). I'll have to figure out how to properly solve this.

spyro2 commented 6 years ago

The correct solution would be to file a bug with Ubuntu (and Debian?), against wx, I think.

MitjaNemec commented 6 years ago

I am not really certain it is a bug in Ubuntu or MacOS, so it would not be fair to raise a bug report. As said, I am looking for a better solution and it looks like I will replace a radiobutton/radiobox with ToggleButton.

MitjaNemec commented 6 years ago

Fixed by Seth Hillbrand