search

MitjaNemec / Kicad_action_plugins

Kicad action plugins
413 stars 62 forks source link

Fix variable misuse introduced by 87bee0e #87

Closed Forty-Bot closed 4 years ago

Forty-Bot commented 4 years ago

Patch 87bee0ecdb1bb640c90fb6a58a680d151d5bb8ff "Bugfix for module path compatibility between 5.1x and 5.99" introduces a bug where get_path always returns 'cleaned_path', even if it has not been set. This patch reverts to the old variable name of 'path'.

MitjaNemec commented 4 years ago

Aaargh, I really need to set CI pipline for 5.1.x and 5.99 as I am way too sloppy. Thanks for spotting this quickly.

libertathiest commented 4 years ago

Hi. If I download the latest version tonight, will I see a change in this? I also noticed the back-annotation works a little better. So it seems that is a work in progress. Thanks all!

MitjaNemec commented 4 years ago

Yes, this hase beem merged to master and I've also fixed the same issue in two other plugins.

Back annotation? Which back annotation?

On March 29, 2020 6:22:18 PM GMT+02:00, libertathiest notifications@github.com wrote:

Hi. If I download the latest version tonight, will I see a change in this? I also noticed the back-annotation works a little better. So it seems that is a work in progress. Thanks all!

-- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/MitjaNemec/Kicad_action_plugins/pull/87#issuecomment-605661778