MitjaNemec / PlaceFootprints

GNU General Public License v2.0
25 stars 5 forks source link

Something wrong when component is about to be flipped #5

Closed tomek-szczesny closed 2 years ago

tomek-szczesny commented 2 years ago

Hi,

I'm heavily testing this tool today :)

I noticed there is a bug in the following case:

However if I invoke the script on a component on a bottom side, and their counterparts have been flipped beforehand by me, error does not occur.

I suspect KiCad has its own unreasonable way of storing orientation data, or perhaps the order of flipping and rotating in the script does matter. I'd guess it should flip, and then rotate.

MitjaNemec commented 2 years ago

Thanks for reporting. I'll have to setup better testing suite. I've just went through similar issue with "Replicate Layout" plugin (yet to be published) when I added an option to replicate on flipped side.

tomek-szczesny commented 2 years ago

Nah, I'm sure all bugs will be reported to you, why would you look for them yourself. :)

MitjaNemec commented 2 years ago

You were right. The plugin placed the footprints first, and then flipped them if needed. I've fixed this, and a new release is available under Releases. But as before, it will take a while, before it is published in PCM

tomek-szczesny commented 2 years ago

No worries, I simply rotated them into correct positions myself, it wasn't that much of a burden. Anyway, thanks again for this excellent plugin. My board is complete now, on time. :)