search

Mitnitsky / Degree-Planer

Apache License 2.0
2 stars 0 forks source link

Support course exemption #3

Closed TalSk closed 5 years ago

TalSk commented 5 years ago

Hi, I would like to see an option to mark a course as exempted. Right now you have to input a grade between 1 and 100 for a course to be included in the calculation, which affects your overall grade, whereas normal exempted courses (like those done in other universities) won't. I tried meddling myself with the Qt code, but both lack of knowledge in your code and Qt in general I couldn't add another column with a tick box to every course. So I'd love that it will be implemented by someone else, or get some direction on how to do it, and I'll do a pull request.

Thanks, and good execution on an amazing idea!

Mitnitsky commented 5 years ago

I don't really think there is a nice way to fit the exemption check in the table because the scaling of the QTable widget is a mess, there is one appropriate way i thought of to mark a course as exempted i could add a grade of -1 to the grades range but that won't intuitive to the users

Mitnitsky commented 5 years ago

Another solution is to add an Exemption category to the combo box in the table, if you find that appropriate tell me :)

TalSk commented 5 years ago

Yeah, the second solution is what I somewhat managed to do myself, just for testing and playing around with the app, you're more than welcome to add this. Thank you :)

Mitnitsky commented 5 years ago

Implemented on Development branch , feel free to try it :)

TalSk commented 5 years ago

Just leaving a comment to say that it works great (apart that now you "don't know" if it's mandatory, A list, B list and such, so it requires manual subtraction)

Mitnitsky commented 5 years ago

Is it possible to get an exemption on a a/b list course?

TalSk commented 5 years ago

Personally all the courses I had exempted are mandatory, but I do know of people that have some from the a/b list.