Overwrite tfvar files doesn't work properly

[eistrati]

I have the following setup:

1) In .recink.yml

your_tf_script_name:
  root: './your_tf_script_path'
  terraform:
    plan: true
    apply: false
    destroy: false
    var-files:
      - prod.tfvars
      - common1.tfvars
      - common2.tfvars
...

2) In CLI

recink run terraform -vv \
  --tf-varfiles="dev.tfvars,common.tfvars"

Expected result: apply values from dev.tfvars and common.tfvars Actual result: apply values from dev.tfvars, common.tfvars and common2.tfvars

[avozicov]

Test Failed

I am facing the following error when running recink run terraform with --tf-vars options Cannot read property 'trim' of undefined

Please refer to attachment for more details:

[avozicov]

I would suggest a minor improvement for the following use case:

• when using custom terraform config with defined var-files it is expected to perform validation for variables content and in case if it is empty return a notification message in console

Actual result:

• case when custom config variables are empty terraform process froze without any debug information

[ddimitrioglo]

@avozicov Fixed in https://github.com/MitocGroup/recink/pull/136. Now --var-files="" or --var-files=" " will be skipped

[ddimitrioglo]

@avozicov FYI. The main requirements for all the FT parameters were described here:

Clarification:
1. --tf-workspace="dev" <==> --custom-config="your_tf_script_name.terraform.current-workspace:dev"
2. --tf-version="0.11.0" <==> --custom-config="$.terraform.version:0.11.0"
3. --include-modules or --exclude-modules && --tf-version="0.11.0" <==> --custom-config="module1.terraform.version:0.11.0,module2.terraform.version:0.11.0,..."
4. --tf-varfiles="v0,v1,..." <==> --custom-config="$.terraform.var-files.0:v0,$.terraform.var-files.1:v1,..."
5. --include-modules or --exclude-modules && --tf-varfiles="v0,v1,..." <==> --custom-config="module1.terraform.var-files.0:v0,module1.terraform.var-files.1:v1,...,module2.terraform.var-files.0:v0,module2.terraform.var-files.1:v1,..."

[avozicov]

Test Passed Acceptance Criteria:

• Case when --var-files are defined in both global and module config it is expected for runner to overwrite global config by the ones provided in line

[eistrati]

Checked.