MitocGroup / recink

REciNK - Rethink Continuous Integration for JavaScript Applications
https://www.npmjs.org/package/recink
Mozilla Public License 2.0
14 stars 5 forks source link

Add an option to define test target by providing full test-file name in test path #128

Closed avozicov closed 6 years ago

avozicov commented 6 years ago

Expected result:

e.x.


  root: './rds_restore'
  terraform:
    version: 0.11.0
    plan: false
    apply: false
    destroy: false
    test:
      mapping: './tests/mapping.json'            
      plan: './tests/unit/resource-name.spec.js' .- expected to run only specified unit test  
      apply: './tests/e2e/resource-name.e2e.js'```- expected to run only specified e2e test  
avozicov commented 6 years ago

I would suggest a minor improvement for the following implementation.

There is an use case when test path validation is still applied for both test types (unit and e2e) even when execution for one of them is set to false or skipped

Steps to reproduce and required configuration:

  1. Set terraform plan to false
  2. Set terraform apply to true
  3. Define an invalid path for unit test component
  4. Define a valid path for e2e test component
  5. Run recink run terraform

Actual behavior:

Expected improvement:

@eugene @ddimitrioglo I would suggest to keep the "qa/review" status for the following ticket till we review and discuss the following improvement

ddimitrioglo commented 6 years ago

@avozicov Fixed

ddimitrioglo commented 6 years ago

@avozicov updates are available in branch issue_116

avozicov commented 6 years ago

Test Passed based on the acceptance criteria defined in the comments above

eistrati commented 6 years ago

Checked.