Global resource config does not override custom module options

[avozicov]

We need to fix the behavior for defining and applying global resource configuration Actual Result:

• Case when plan, apply, destroy options are set to true in global terraform config they are not applied to custom modules configuration

Please use the following config and commands to reproduce the issue:

• apply a resource with the name qa-resource
• run recink run terraform with destroy option set to true

  ---
  $:
  preprocess:
  '$.terraform.vars.access_key': 'eval'
  '$.terraform.vars.secret_key': 'eval'
  '$.terraform.vars.region': 'eval'
  '$.terraform.cache.options.1.region': 'eval'
  '$.terraform.cache.options.1.accessKeyId': 'eval'
  '$.terraform.cache.options.1.secretAccessKey': 'eval'
  emit:
  pattern:
    - /.+\.js$/i
  ignore:
    - /^(.*\/)?node_modules(\/?$)?/i
  terraform:
  resource: '.resource'
  cache: 
    options:
        - 's3://[your_bucket_name]'
        -
          region: 'process.env.AWS_DEFAULT_REGION'
          accessKeyId: 'process.env.AWS_ACCESS_KEY_ID'
          secretAccessKey: 'process.env.AWS_SECRET_ACCESS_KEY'
  plan: false
  apply: false
  destroy: true
  vars:
    access_key: 'process.env.AWS_ACCESS_KEY_ID'
    secret_key: 'process.env.AWS_SECRET_ACCESS_KEY'
    region: 'process.env.AWS_DEFAULT_REGION'
  qa-resource:
  root: './qa-resource'
  terraform:
  version: 0.11.0
  var-files:
    - qa.tfvars 

  Please refer to attachment for more details:

[ddimitrioglo]

@avozicov could not reproduce with the following config:

---
$:
  preprocess:
    '$.terraform.vars.access_key': 'eval'
    '$.terraform.vars.secret_key': 'eval'
    '$.terraform.vars.region': 'eval'
  emit:
    pattern:
      - /.+\.js.*$/i
    ignore:
      - /^(.*\/)?node_modules(\/?$)?/i
  terraform:
    resource: '.resource'
    plan: false
    apply: false
    destroy: true
    vars:
      access_key: 'process.env.AWS_ACCESS_KEY_ID'
      secret_key: 'process.env.AWS_SECRET_ACCESS_KEY'
      region: 'process.env.AWS_DEFAULT_REGION'

iam2:
  root: './iam'
  terraform:
    cache: false

Please let me know if I'm missing something

[avozicov]

@ddimitrioglo I can confirm that the issue is not reproduced anymore on my side as well. I have successfully executed the plan for my resource using plan: true option defined in the global terraform config

[eistrati]

Checked.