search

MitsubaBBS / Mitsuba

Project Mitsuba - an opensource imageboard software written in PHP
http://mitsuba.cf/
Other
43 stars 20 forks source link

Use PDO over mysqli. #64

Open russelg opened 10 years ago

russelg commented 10 years ago

I've had a scan through the code, and I can say all of this string escaping is pretty gross. If you continue to stick with mysqli, at least try to make use of prepared queries.

I'm not on my main PC, so I can't actually do a pull request to implement PDO at the moment, but I will try ASAP.

(This is if you actually would like to move to PDO :)

russelg commented 10 years ago

also the front page for boards never updates, and new posts don't show on the homepages.

Desuneko commented 10 years ago

I'd be glad if you could make this.

Also, I'm aware about the frontpage issue, but I'm lazy.

ekem commented 10 years ago

If you approached the additions to the db in an OOP way and constucted a db control class this would be much easier to implement. Would be nice to use postgres on the db backend

russelg commented 10 years ago

Sorry I never got around to doing this, the structure of the code here was kinda confusing me so I gave up (lol)