Mitsunee / fgo-timers

Fansite for the global version of Fate/Grand Order with Event Timers, info on future Upgrades, Interludes, Rank Ups, Login Exchange Tickets and Calculators
https://fgo.mitsunee.com
7 stars 1 forks source link

Special Cases in upgrades data #6

Closed Mitsunee closed 2 years ago

Mitsunee commented 3 years ago

This issue currently does not require immediate action and merely serves as a note for the future!

Jekyll&Hyde and Fairy Knight Lancelot are currently disabled in the upgrades data script:

https://github.com/Mitsunee/fgo-tools/blob/6facb4b95b2b7c1a490069b49378fc954db8d4ca/scripts/update-upgrades-data.mjs#L82-L86

Jekyll&Hyde's data is split between the servant (id:600700) and enemy (id:600710). This might not currently be causing any issues, but still needs to be checked. Showing the data for both in the app probably adds too much extra code.

Fairy Knight Lancelot (id:304800) uses different skill and NP data depending on ascension level. As they are right now they use priority 1 and 2, and 101 and 102 respectively, just like upgrades would. Thus the current code to find the initial versions of upgraded skills may get confused if she were to ever get any upgrades related to her S3 or NP.

Other Servants who have non-standard data (that are currently expected to be working correctly) are:

Mitsunee commented 3 years ago

Removed Jekyll from filter during refactor in https://github.com/Mitsunee/fgo-tools/commit/1f61d566c3089a1e1ecc17ab37396b8f94a67314