Add typescript and upgrades data upgrades to prebuild script

[Mitsunee]

• [x] Setup typescript
• [x] update eslint configs
• [x] rewrite scripts and SSG/ISR to use @atlasacademy/api-connector instead of picoapi
• [x] refactor npm scripts to implement typescript build into workflow
  • [x] Rewrite prebuild script to create cut-down versions of basic_servant etc. as needed
  • [x] migrate check script
  • [x] Use zod for Schema validation
  • [x] svgo components are now built in separate script that runs during prepare or can be forced to rerun with yarn build:svgo. yarn prebuild will also force-rebuild!
  • upgraded to svgo 3.0
• [x] add typecheck job to test CI job
• [x] fix caching in CI
• [x] Remove legacy upgrades data script
• [x] Rewrite Upgrades script to use new data structure that doesn't duplicate servant data
  • actually properly support EoR-censored NPs (aka de-censor them where possible)
  • upgrades.json now only contains upgrades with quests in quests.json (generated by prebuild phase 3) instead.
• [x] API Route to retrieve full dataset for static bundles (servants, quests, ...)
• [x] Refactor UpgradesPage SSG to only contain data required for initial load and fetch remaining data from new api route
• [x] Refactor UpgradesPage to tsx
• [x] Rework spoiler system to be more SSR-friendly
• [x] remove now unused dependencies (picoapi, node-fetch)
• [x] #84
• [x] Rewrite SettingsMenu and add selector for autoInfiniteScroll

Known Issues:

• had to use tsm to run tests and scripts as typescript incorrectly builds esm
  • using tsm throws various warnings, some of which are silenced with --require=nowarn.js
  • tsm is not able to use tsconfig.compilerOptions.basePath and tsconfig.compilerOptions.paths which thus cannot be used in anything related to legacy tests or scripts
  • tsm is unable to import cjs files with module.exports.default. Requires separating some utils between scripts (need to import and destructure the main entrypoint) and frontend (needs to import the file directly to manually do the treeshaking cjs files cannot do)
  • tsm hijacks the --help option of scripts
• jest tests currently do not prepareCache(). Can this be done prior so it isn't reran for every test?
  • investigate --globalSetup option
• uvu tests are now technically deprecated and have been moved to ./tests/scripts-uvu and will have to be replaced with jest tests (at which point tsm is not needed for testing anymore)
  • might remove these before merging?
• once scripts are fully migrated to typescript tsm will not be needed for running scripts anymore

Notes:

• might try tsx instead of tsm, if that works better might skip the compile step altogether
  • tsx doesn't seem to work with the partially migrated scripts, will try again when everything is typescript
• some of the bundlers currently have no data to produce, so they could still have unknown issues.

Deprecations:

The following things are deprecated and should not be used in new code as they are planned to be removed later:

• FGOIcon Component
• InlineIcon Component (renamed to InlineIconLegacy)
• useFormatted* hooks (replaced with TimeDisplay component set)
• default exports on: NoSSR, Clocks, Input
• setSetting action of settingsStore
• timeFormatsMap
• InputNumber component (replaced with named export of Input)
• UpgradeCard (reimplemented in ./src/pages/UpgradesPage/components)
• withSpoilerLevel
• withAddedProps

Required Cleanup after merge:

• Removals of deprecated components/hooks
• lowering bundle size (entire api-connector package is shipping due to it being cjs and typescript doesn't understand the default imports in dist)
• Any changes (related) to SpecialTimer
  • SpecialTimer is a blocker for removing useFormatted(Spacetime|Timestamp|Estimate|Delta|DeltaFrom) hooks
  • Above hooks are a blocker for removing timeFormatsMap
  • cannot change default import of NoSSR in HomePage (usually used for SpecialTimer)
• delete legacy upgrades data file

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
fgo-timers	✅ Ready (Inspect)	Visit Preview	Dec 23, 2022 at 3:48PM (UTC)

[github-actions[bot]]

yarn.lock changes

Summary

Status	Count
	37
	22
	7

Click to toggle table visibility

| Name | Status | Previous | Current | | :- | :-: | :-: | :-: | | `@atlasacademy/api-connector` | [](#) | - | 3.0.126 | | `@atlasacademy/api-descriptor` | [](#) | - | 1.0.139 | | `@esbuild/linux-loong64` | [](#) | - | 0.14.54 | | `@foxkit/util` | [](#) | - | 0.6.2 | | `@humanwhocodes/config-array` | [](#) | 0.10.4 | 0.10.5 | | `@types/json-schema` | [](#) | - | 7.0.11 | | `@types/node` | [](#) | 18.7.14 | 18.7.21 | | `@types/react` | [](#) | 18.0.14 | 18.0.21 | | `@typescript-eslint/eslint-plugin` | [](#) | - | 5.38.1 | | `@typescript-eslint/parser` | [](#) | 5.30.0 | 5.38.1 | | `@typescript-eslint/scope-manager` | [](#) | 5.30.0 | 5.38.1 | | `@typescript-eslint/type-utils` | [](#) | - | 5.38.1 | | `@typescript-eslint/types` | [](#) | 5.30.0 | 5.38.1 | | `@typescript-eslint/typescript-estree` | [](#) | 5.30.0 | 5.38.1 | | `@typescript-eslint/utils` | [](#) | - | 5.38.1 | | `@typescript-eslint/visitor-keys` | [](#) | 5.30.0 | 5.38.1 | | `axios` | [](#) | - | 0.27.2 | | `css-select` | [](#) | 4.1.3 | 5.1.0 | | `css-tree` | [](#) | 1.1.3 | 2.2.1 | | `css-what` | [](#) | 5.1.0 | 6.1.0 | | `csso` | [](#) | 4.2.0 | 5.0.5 | | `data-uri-to-buffer` | [](#) | 4.0.0 | - | | `dom-serializer` | [](#) | 1.3.2 | 2.0.0 | | `domelementtype` | [](#) | 2.2.0 | 2.3.0 | | `domhandler` | [](#) | 4.2.2 | 5.0.3 | | `domutils` | [](#) | 2.8.0 | 3.0.1 | | `esbuild-android-64` | [](#) | - | 0.14.54 | | `esbuild-android-arm64` | [](#) | - | 0.14.54 | | `esbuild-darwin-64` | [](#) | - | 0.14.54 | | `esbuild-darwin-arm64` | [](#) | - | 0.14.54 | | `esbuild-freebsd-64` | [](#) | - | 0.14.54 | | `esbuild-freebsd-arm64` | [](#) | - | 0.14.54 | | `esbuild-linux-32` | [](#) | - | 0.14.54 | | `esbuild-linux-64` | [](#) | - | 0.14.54 | | `esbuild-linux-arm` | [](#) | - | 0.14.54 | | `esbuild-linux-arm64` | [](#) | - | 0.14.54 | | `esbuild-linux-mips64le` | [](#) | - | 0.14.54 | | `esbuild-linux-ppc64le` | [](#) | - | 0.14.54 | | `esbuild-linux-riscv64` | [](#) | - | 0.14.54 | | `esbuild-linux-s390x` | [](#) | - | 0.14.54 | | `esbuild-netbsd-64` | [](#) | - | 0.14.54 | | `esbuild-openbsd-64` | [](#) | - | 0.14.54 | | `esbuild-sunos-64` | [](#) | - | 0.14.54 | | `esbuild-windows-32` | [](#) | - | 0.14.54 | | `esbuild-windows-64` | [](#) | - | 0.14.54 | | `esbuild-windows-arm64` | [](#) | - | 0.14.54 | | `esbuild` | [](#) | - | 0.14.54 | | `eslint-config-foxkit` | [](#) | 1.1.1 | 2.0.0 | | `eslint-plugin-no-await-in-promise` | [](#) | - | 1.1.1 | | `eslint` | [](#) | 8.23.1 | 8.24.0 | | `fetch-blob` | [](#) | 3.1.5 | - | | `follow-redirects` | [](#) | - | 1.15.2 | | `formdata-polyfill` | [](#) | 4.0.10 | - | | `install` | [](#) | - | 0.13.0 | | `mdn-data` | [](#) | 2.0.14 | 2.0.28 | | `node-domexception` | [](#) | 1.0.0 | - | | `node-fetch` | [](#) | 3.2.10 | - | | `nth-check` | [](#) | 2.0.1 | 2.1.1 | | `only` | [](#) | - | 0.0.2 | | `picoapi` | [](#) | 0.2.0 | - | | `svgo` | [](#) | 2.8.0 | 3.0.0 | | `swr` | [](#) | - | 1.3.0 | | `tsm` | [](#) | - | 2.2.2 | | `typescript` | [](#) | 4.8.3 | 4.8.4 | | `web-streams-polyfill` | [](#) | 3.2.1 | - | | `zod` | [](#) | - | 3.19.1 |

[Mitsunee]

https://github.com/Mitsunee/fgo-timers/pull/77/commits/65e463354f3e905696c6735018b9c655e279d362 broke CI by causing a merge conflict...

[Mitsunee]

This and following build error expected due to static data bundlers not being implemented yet.

[Mitsunee]

deployment errors should now stop

[Mitsunee]

I have no clue how vercel is failing to find the types for commander

[Mitsunee]

not sure with CI job is failing, the package is installed and present during preview deployments.