MiuLab / SlotGated-SLU

Slot-Gated Modeling for Joint Slot Filling and Intent Prediction
304 stars 108 forks source link

Is the model in code matches what is described in the paper? #3

Open YuanTingHsieh opened 6 years ago

YuanTingHsieh commented 6 years ago

In the first attention block, You get hidden features using a filter AttnW to conv. with state outputs, I believe that's the formula W h_k, BUT you also have state outputs pass through a linear layer and get y Then you add y and hidden features then pass through an tanh then multiply by a matrix

In the paper, I only see tanh(W h_k)

Also in your code there is AttnV, where I can't find corresponding description in the paper.

The paper only has gate V and gate W

Could you kindly explain this? I am really confusing. Thank you!

nwy2010 commented 5 years ago

Yes, I have the same doubts